Repository navigation
Conversation
The heatmap counted a streak from the collection's review days alone, so a day a streak freeze covered broke it, while the AnkiQuest widget, which counts the server's streak, carried on: a freeze on 28 October left the heatmap at 1 day against a longer streak on the widget. The heatmap now reads the frozen days from the AnkiQuest profile once the collection has been drawn, and counts them as the server does, keeping a streak without lengthening it. Such days have a blue outline and say so when tapped. Without AnkiQuest set up, or offline, the heatmap is as before.
The revlog records when a review happened but not under which clock, so the heatmap numbered every day by the device's present one. Reviews studied on a flight through time zones landed on a neighbouring day and left an empty one, which broke the heatmap's streak while AnkiQuest's carried on. AnkiQuest records each clock as it is reported and numbers reviews by the one in force, so its per-day counts are now used from the first day it has reviews for up to the day before the last review it was sent. Today and the days the server has not been sent stay the collection's.
|
Snapshot diff report vs
All 16 changed screenshotsCustomStudyScreenshotTest
DeckPickerScreenshotTest
DeckPickerTabletScreenshotTest
NavigationDrawerScreenshotTest
ReviewRemindersScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heatmap numbered every review's day by the device's present clock, because the revlog does not record which clock a review was studied under. Reviews made on a flight through time zones landed on a neighbouring day and left an empty one, so the heatmap's streak broke where the widget's AnkiQuest streak carried on.
Known limit: "View reviewed cards" still searches Anki's own day windows, so for a day the server renumbered it can list a neighbouring day's cards.