fix: stop the GitHub ribbon covering the theme toggle - #221
Merged
Conversation
The ribbon is 149px wide and pinned to the top-right of the viewport at z-index 9999, which is also where the navbar ends. It was shown from lg up, but it only clears the theme toggle once the margin beside the page card exceeds 149px less the 28px of padding the toggle already sits inside -- from a viewport of container + 242px, or 1382px against the 1140px container. Below that the whole 149px square, all of it inside the link, sat on top of the toggle and took its clicks; below 1200px it reached Internships as well. Showing it from xxl instead is the first breakpoint past that threshold. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Fork me on GitHub" ribbon is 149px wide and pinned to the top-right of the viewport at
z-index: 9999— the same corner the navbar ends in. It was shown fromlgup.It only clears the theme toggle once the margin beside the page card,
(viewport - container) / 2, exceeds the ribbon's 149px less the 28px of navbar and container padding the toggle already sits inside: 121px, so fromviewport = container + 242px. Against the 1140px the container is capped at, that is 1382px.Below that the ribbon sat on top of the toggle — and since the whole 149px square is inside the
<a>, it took the clicks meant for it, so the toggle was unreachable on an ordinary 1280 or 1366 laptop. Below 1200px, where the container drops to 960px, it reached "Internships" as well.d-none d-xxl-blockis the first breakpoint past the threshold, clearing it by 9px — and by more from there on, since the 1140px cap inglobal.cssstops the container growing to meet it. That dependency is noted in the comment above the ribbon.Not addressed here: between 992px and 1199px the nav row needs ~1030px against a 960px container, so "Get Started" still wraps to two lines. Separate change.
🤖 Generated with Claude Code