fix: update the TextMate grammar and colour pub with the other keywords - #216
Merged
Conversation
Bump the pinned flix/textmate commit from befa883 to 1da5462, which adds function-name highlighting, widens the type rule beyond the primitives, and renames the pub modifier's scope to storage.modifier.flix. That rename alone left pub blue. The theme override here appends a rule for a bare storage, but TextMate resolves a token to the most specific matching selector rather than the last one written, and Light+ ships its own storage.modifier rule in blue. Name storage.modifier explicitly so the override ties on specificity and wins on order. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned flix/textmate commit from
befa883to1da5462, and fixes a theme override that keptpubblue.Grammar
Upstream changes picked up by the bump:
foo(...)getsentity.name.function,List.mapgetssupport.functionpubmoves fromstorage.type.modifier.flixtostorage.modifier.flixdbg,resume,typematch,law,without,opaque,handler,xvar,branch,jumpto, andlawfulare droppedWhy
pubstayed blueThe scope rename on its own changed nothing on the site.
CodeSnippet.astroappends a rule for a barestorageto make every Flix keyword magenta, but TextMate resolves a token to the most specific matching selector rather than the last one written — and Light+ ships its ownstorage.modifierrule in blue. A barestorageloses to it, just as it previously lost tostorage.type.Naming
storage.modifierexplicitly ties on specificity, so the override wins on order.pub def foo(): Int32 = 42rendered through the site's theme:pubdeffooInt32#0000FF#AF00DB#267F99#AF00DB#AF00DB#795E26#267F99🤖 Generated with Claude Code