Repository navigation
docs(doc-review): daily review 2026-10-29 — RUM chart estimates and exact queries, trend granularity, incident Issue info - #1151
Open
flashduty[bot] wants to merge 1 commit into
Open
flashduty[bot] wants to merge 1 commit into
flashduty[bot] wants to merge 1 commit into
Conversation
…rend at 3 granularities - new page zh|en/rum/analytics/chart-readings.mdx (+ docs.json nav): the Estimate mark, per-chart Exact query with retry, the per-account exact-query allowance, and the trend chart's granularity / cumulative controls - on-call: the incident detail's new Issue info block for RUM alerts - monitors: __alert_rule_relate_query_error when a related query fails - changelog: 2026-10-29 entry for the two RUM dashboard features
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-10-29
Mode: diff (since
2026-10-28T08:14:27Z→2026-10-29T08:10Z)Findings: 8 total — 1 high, 5 medium, 2 low (4 applied, 2 held, 2 skipped / already covered)
Changes
zh/rum/analytics/chart-readings.mdx+en/…docs.jsonReview checklist
Sources read before writing (all
origin/main):fc-saas-rum pages/Dashboard/components/ChartCard/SamplingMark.tsx,pages/Dashboard/components/TrendChart/{TrendControls,granularity,useTrendSeries}.ts(x),pages/Dashboard/modules/{useDashboardData,useDashboradStore}.ts,pages/Dashboard/locales/{zh_CN,en_US}.json(UI strings reused verbatim in both languages),fc-rum config/config.go,logic/dataquery/limiter.go,cmd/server/controller/data/{types,cache}.go,fc-saas-web pages/Incident/NewDetail/RumIssueInfo.tsx+Overview/RightContainer/index.tsx,monit-webapi types/alert_rule_labels.go,logic/logic_alert_rule_lifecycle_v2.go.Held
check_threshold.absent_counts_as_normal, monit-webapi merged; FE in fc-saas-monit#527 open): already documented by the open docs(monitors): document counting absent alert objects as normal for threshold recovery #1147 in the same file. Not resubmitted — covered by docs(monitors): document counting absent alert objects as normal for threshold recovery #1147. The api side is in docs(api-reference): daily api-review 2026-10-29 — drop license release_limited, add rum cumulative, monit absent_counts_as_normal #1150. My f004 edit touches the 关联查询 row of the 事件配置 table, well away from docs(monitors): document counting absent alert objects as normal for threshold recovery #1147's 告警恢复 section, so the two should merge without a text conflict (same file, different hunks).logic/ai_sre/chat_settings.go,channel_config_migration.go, and the Teams ordinary-group binding incmd/engine/controller/notify/teams_inbound.go): the feature sits behindaiSreNlSettings, default false, turned on per rollout. While it is off, a reader following the doc gets "请使用 /env 或 /scope". Held until the switch is on in customer environments.Cross-repo follow-ups (flashduty-website)
None. The window's website changes (
flashduty-websitee1a5ff6…) are analytics/attribution plumbing (PostHog, entry-referrer, lead form) and the console-link components — no changelog or integrations-catalog gap a docs change would create.Mapping warnings
fc-event—cmd/engine/controller/notify/(teams_app.go,teams_inbound.go),logic/onboarding/,cmd/server/controller/onboarding/,structs/ai_sre.go,logic/resource/usage.go,structs/license.goare not mapped. The Teams inbound/AI-SRE ownership change in this window is entirely undercmd/engine/controller/notify/, so a mapping-driven scan misses it. Suggest addingcmd/engine/controller/notify/toon-call/integration/instant-messagingandstructs/ai_sre.gotoai-sre.fc-foundation-app— the status page console is atsrc/Packages/saas/pages/StatusPage, butstatuspagemaps onlysrc/Packages/saas/pages/Dashboard. Alsosaas/pages/OnboardingOncall,saas/pages/Onboarding,saas/pages/Guideare mapped to no module.fc-rum—cmd/server/controller/data/(where this window's sampling /cumulative/time_zonework lives) is not mapped; onlylogic/andtypes/.flashduty-docs—derivative_surfaces.comparison_pagepoints atzh|en/on-call/quickstart/comparison.mdx, which does not exist (the comparison pages arezh|en/on-call/comparison/vs-pagerduty.mdxandvs-opsgenie.mdx), so that derivative check keeps silently no-op'ing.mcp-server/terraformdocs_pathare directories (developer/mcp-server/,developer/terraform/) that don't exist; the pages arezh|en/developer/mcp-server.mdxandterraform.mdx.Skipped
docs.flashcat.cloud/zh/monitors/alert-rules(fc-saas-monit pages/onboarding/monitTasks.ts:129, previously…/rule-repository/rule-repository).https://docs.flashduty.com/zh/monitors/alert-rulesanswers307to/zh/monitors/alert-rules/prometheus— not a 404, so nothing to fix here; landing on the Prometheus rule page rather than an overview is a product-side choice.logic/benchmark/v2,cmd/api/benchmark{,v2}): authenticated withconfig.C.Benchmark.AccountID, no console entry in any frontend repo (grep benchmark= 0 hits in saas/monit/rum/ai-sre/ai-assistant) → internal eval harness, not a public feature.structs/license.go,logic/resource/usage.go-141 lines,LicenseReleaseLimitedCountmetric dropped): no doc page claims a release quota, so nothing is stale.logic/charge/arrears.go, reminder emails): internal billing notifications, no user-visible console surface.pages/rule/add/…/preview/previewColumns.ts) and the metric-definition fixes (ANR rate join onts, crash ranking byview_name, Electron synthetic view excluded from PV/error rate, crash-free-on empty windows) keep the console numbers correct without changing what the docs assert.Validation
mint broken-links(Node 20.18.0, mint via npm): exit 1 withwarnin skipped 36 file(s) that could not be parsed— all 36 are pre-existing parse errors underon-call/integration/alert-integration/alert-sources/, and the log ends withsuccess no broken links found in the files that parsed.comm -12between this branch's changed files and the 36 skipped files is empty, so every file this PR touches was link-checked.jq empty docs.jsonpasses.