Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000 (no issue: documents flarum/framework#5199)
Changes proposed in this pull request:
Documents the icon picker that flarum/framework#5199 adds in Flarum 2.1.
fontawesome.mdgets a "Choosing an Icon" section: what the picker lists for each Font Awesome source, how to use an icon it doesn't list, and that assets on another domain needAccess-Control-Allow-Originfor icons to be listed. The tags page's Icon field points to it. For extension developers,admin.mdadds theiconsetting type,forms.mdtheIconInputcomponent, andcode-splitting.mdnotes thatIconPickeris a lazy core module.Reviewers should focus on:
Screenshot
N/A
Necessity
Confirmed
yarn testinjs/). (No code changes.)composer test). (No code changes.)