Repository navigation
Replace the "Coming Soon!" end-to-end testing stub with the actual situation - #599
Open
karl-bullock wants to merge 1 commit into
Open
karl-bullock wants to merge 1 commit into
karl-bullock wants to merge 1 commit into
Conversation
…tuation The testing guide ended with an "## E2E Tests" heading whose entire body was "Coming Soon!", which has been shipping in the 2.x docs while nothing in the framework backs it: there is no Playwright, Cypress, Puppeteer or Selenium dependency anywhere in the monorepo, and no e2e directory in core or any bundled extension. Rather than leave a promise with no timeline behind it, the section now says plainly that Flarum ships no end-to-end harness, points out that integration tests already cover much of the same ground because they boot a real app and exercise real requests against a real database, names what they genuinely cannot reach (the browser, so rendering and navigation), and tells anyone who needs that layer that they are bringing their own tooling and pointing it at a running install. Cross-references use the two top-level section anchors rather than "Using Integration Tests", which appears twice on the page and therefore has a positional anchor.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testing guide ends with an
## E2E Testsheading whose entire body isComing Soon!. That has been shipping in the 2.x docs, and nothing in the framework backs it: there is no Playwright, Cypress, Puppeteer or Selenium dependency anywhere in the monorepo, and noe2edirectory in core or in any bundled extension. It is a promise with no timeline attached, in a spot where a reader following the page's table of contents lands expecting content.Rather than delete the heading outright, the section now says what is actually true, which is more useful than either the stub or silence:
Cross-references deliberately use
#backend-testsand#frontend-testsrather than#using-integration-tests, because "Using Integration Tests" appears twice on this page and so the second one has a positional-1anchor that moves if a section is added above it. Same reasoning as #595.If the team would rather keep this as a stub because an E2E harness is actually planned, I am happy to close this instead. I could not find any sign of one in the framework, which is why I assumed not.
Verified with
npx docusaurus build --locale en: no errors, and Docusaurus reports no broken anchors on the page.