Repository navigation
Drivine 0.4.0 - #61
Merged
Merged
Conversation
Moves Drivine from 0.3.0 to 0.4.0, in the pom and in codegen-gradle. The embabel-agent-rag-graph and embabel-chat-store snapshots, built on 0.3.0, link with 0.4.0. The Jackson 2.21 pin's comment now gives the reasons that still hold: Drivine no longer needs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Drivine from 0.3.0 to 0.4.0, in the pom and in
codegen-gradle/build.gradle.kts, with embabel-agent-rag-graph and embabel-chat-store (embabel/embabel-agent-rag-graph#74, embabel/embabel-chat-store#51).Safe to merge now, in any order with those two. Drivine 0.4.0 is binary-compatible with the rag-graph 0.6.0 and chat-store 0.7.0 snapshots the Guide resolves today, which are built on 0.3.0. Every Drivine method and field they link to is still there (checked with
javap), and the Guide's tests are green with them on 0.4.0. No new library builds are needed first.Why
Drivine 0.4.0's changes are in its Cypher-to-SQL compilers and its Oracle, Postgres and SQLite backends: a SQL store's graph tables are made on its first connection, Oracle sessions make no adaptive plan, and long texts and temporal lists read correctly on Oracle. The schema specs, annotations, object managers, starter and codegen are unchanged. No source changes.
The Jackson 2.21 pin
Its comment said Drivine needs Jackson 2.21. That was true of 0.0.73, which used
JsonSerializeAs, but Drivine 0.4.0 builds on Jackson 2.19.2 and uses no 2.21 API. The pin stays as it is. The comment now gives the reasons that still hold: Boot 4's Jackson 3 uses the Jackson 2 annotations at 2.21, and jinjava, the MCP SDK and Tika ask for 2.20 or 2.21.Boot 4.1.1 now manages Jackson 2 at 2.21.5 itself, so the pin holds
jackson-databindandjackson-coreone patch below Boot (2.21.4). It looks removable, but that is left for a separate change.Tested
Against drivine4j 0.4.0 from Maven Central, in a fresh local Maven repository so the rag-graph and chat-store snapshots came from repo.embabel.com as published (
0.6.0-20261026.030308-17and0.7.0-20261028.080445-59, both on Drivine 0.3.0):codegen-gradlegenerates the DSL against 0.4.0, andmvn verifyis green, 183 tests on Neo4j and Postgres in Testcontainers, 0 failures, 0 skipped.