class stereotype - #446
Open
shengzhangscore wants to merge 2 commits into
Open
Conversation
shengzhangscore
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
August 27, 2026 08:12
shengzhangscore
force-pushed
the
sheng_class_stereotype
branch
from
August 27, 2026 08:28
e22974b to
34d5271
Compare
shengzhangscore
force-pushed
the
sheng_class_stereotype
branch
from
August 27, 2026 09:23
34d5271 to
5988c9f
Compare
SebSparrowHawk
approved these changes
Aug 28, 2026
LittleHuba
reviewed
Aug 28, 2026
| }, | ||
| "namespace": "", | ||
| "package": "", | ||
| "stereotype": "Singleton, Immutable", |
Contributor
There was a problem hiding this comment.
Why did you change from Vec<String> to Option<String>? Now users have to separate the elements in this string by hand. I would prefer if we go back to Vec<String> and do this separation internally.
Contributor
Author
There was a problem hiding this comment.
Other diagrams, such as component and sequence diagrams, use Option<String> for consistency. So change this to Option<String>. Do you mean it is better to change all stereotype to stereotypes?
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.