AZB #101279 Quality pack targets - #150
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
This doesn't match up with the score process module_template.
I've started the component requirements work for the other components following the guidelines, see #151 and #149. I think we should have this structure across all the components. The actual build of the docs themselves won't work until the update to docs-as-code 6.0 is merged in #148 (updating to use docs_bundles so that we can have docs alongside source).
Please update to match the template.
There was a problem hiding this comment.
I pushed the commit Update to match module_template , to match the template. However, like you said, until docs-as-code 6.0 isn't merged this will not work as we get:
"broken_references": [
{
"testcase": "testcase__SystemClockTest__NowReturnsTimepointSuitableForDurationArithmetic_nckqh",
"missing_need": "comp_req__system_time__snapshot"
},
{
"testcase": "testcase__SteadyClockTest__NowReturnsTimepointSuitableForDurationArithmetic_dhwjw",
"missing_need": "comp_req__steady_time__snapshot"
},
{
"testcase": "testcase__HighResSteadyClockTest__NowReturnsTimepointSuitableForDurationArithmetic_ogazc",
"missing_need": "comp_req__high_res_steady_time__snapshot"
},
{
"testcase": "testcase__VehicleClockTest__NowReturnsSynchronizedStatusAndTimepoint_xggob",
"missing_need": "comp_req__vehicle_time__snapshot"
},
{
"testcase": "testcase__VehicleClockTest__InitForwardsToBackend_vsaqs",
"missing_need": "comp_req__vehicle_time__lifecycle"
}
]
160bc42 to
7444a7c
Compare
…ality-pack-targets
…ality-pack-targets
…ality-pack-targets
…ality-pack-targets
There was a problem hiding this comment.
Feature requirements should be in eclipse-score/score repo, not the module repo itself - should these be component requirements?
There was a problem hiding this comment.
Your right. Removed feature requirements as they belong to eclipse-score/score repo.
There was a problem hiding this comment.
Created them as component requirements
| :valid_from: v1.0 | ||
| :satisfied_by: feat__time | ||
|
|
||
| Clock domains that depend on an external resource (currently |
There was a problem hiding this comment.
We should avoid having implementation details e.g. method names etc like this in the requirements. Review the requirements you've added here against the requirements checklists
There was a problem hiding this comment.
Removed feature requirements as they belong to eclipse-score/score repo
Remove feature requirements as they belong to eclipse-score/score repo
…ality-pack-targets
Provide Bazel targets: unit tests, component tests, code coverage.
Added documentation