Skip to content

removed strings in minimizer indexing mechanism #347 - #348

Open
rozyczko wants to merge 1 commit into
release-3.0from
347-enum-minimizers
Open

rozyczko wants to merge 1 commit into
release-3.0from
347-enum-minimizers

Conversation

@rozyczko

Copy link
Copy Markdown
Member

The Fitter.switch_minimizer method now only accepts AvailableMinimizers enum members, raising a TypeError if a string or invalid type is provided. The old create method and the from_string_to_enum conversion function are removed

The available_minimizers property now returns a list of enum members instead of strings.

@rozyczko rozyczko added [area] fitting Umbrella for fitting related work [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] highest Urgent. Needs attention ASAP labels Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.67%. Comparing base (7200b07) to head (d95f071).
⚠️ Report is 12 commits behind head on release-3.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0     #348      +/-   ##
===============================================
- Coverage        92.75%   92.67%   -0.08%     
===============================================
  Files               47       47              
  Lines             3408     3372      -36     
===============================================
- Hits              3161     3125      -36     
  Misses             247      247              
Flag Coverage Δ
unittests 92.67% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/fitting/available_minimizers.py 84.61% <ø> (-4.78%) ⬇️
src/easyscience/fitting/fitter.py 94.56% <100.00%> (-0.49%) ⬇️

... and 1 file with indirect coverage changes

fitter.switch_minimizer('Bumps')
from easyscience import AvailableMinimizers

fitter.switch_minimizer(AvailableMinimizers.Bumps)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting the minimizer allows me to remove create entirely.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] fitting Umbrella for fitting related work [priority] highest Urgent. Needs attention ASAP [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant