Skip to content

[patch] Improved accessibility issues in Popover #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PelayoFelgueroso merged 3 commits into from
Aug 20, 2026
Merged

[patch] Improved accessibility issues in Popover #2529

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8a317
Improved accessibility issues in Popover
Jialecl Aug 20, 2026
0c69942
removed asChild from trigger
Jialecl Aug 20, 2026
affdd8d
remove button default styling
Jialecl Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 37 additions & 24 deletions packages/lib/src/popover/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,32 +57,45 @@ const DxcPopover = ({
return (
<>
<Popover.Root open={isControlled.current ? isOpen : opened}>
<Popover.Trigger aria-controls={undefined} asChild>
{asChild ? (
children
) : (
<PopoverWrapper
role="button"
onClick={
actionToOpen === "click"
? () => handleTrigger(isControlled.current, setOpened, true, onOpen)
: undefined
}
onMouseEnter={
actionToOpen === "hover"
? () => handleTrigger(isControlled.current, setOpened, true, onOpen)
: undefined
}
onMouseLeave={
actionToOpen === "hover"
? () => handleTrigger(isControlled.current, setOpened, false, onClose)
: undefined
}
>
{asChild ? (
<Popover.Trigger
aria-controls={undefined}
aria-expanded={undefined}
aria-haspopup={undefined}
type={undefined}
asChild
>
{children}
</Popover.Trigger>
) : (
<Popover.Trigger
style={{
backgroundColor: "transparent",
border: "none",
margin: 0,
padding: 0,
textAlign: "inherit",
font: "inherit",
borderRadius: 0,
appearance: "none",
}}
onClick={
actionToOpen === "click" ? () => handleTrigger(isControlled.current, setOpened, true, onOpen) : undefined
}
onMouseEnter={
actionToOpen === "hover" ? () => handleTrigger(isControlled.current, setOpened, true, onOpen) : undefined
}
onMouseLeave={
actionToOpen === "hover"
? () => handleTrigger(isControlled.current, setOpened, false, onClose)
: undefined
}
>
<PopoverWrapper role="button" aria-controls={popOverId} aria-expanded={opened} aria-haspopup={true}>
{children}
</PopoverWrapper>
)}
</Popover.Trigger>
</Popover.Trigger>
)}
{portalContainer && (
<Popover.Portal container={portalContainer}>
<Popover.Content
Expand Down
Loading