Skip to content

GH-1063: Add is_update field to ActionCreatePreparedStatementResult (… - #32

Merged
lriggs merged 1 commit into
dremio:dremio_27.0_23_19from
lriggs:cherrypick3
Aug 18, 2026
Merged

GH-1063: Add is_update field to ActionCreatePreparedStatementResult (…#32
lriggs merged 1 commit into
dremio:dremio_27.0_23_19from
lriggs:cherrypick3

Conversation

@lriggs

@lriggs lriggs commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

apache#1064)

What's Changed

A new field, optional bool is_update = 4;, was added to message ActionCreatePreparedStatementResult. When this field is sent by the server, its value indicates whether the proper network flow to execute the query that the driver should follow uses
CommandPreparedStatementQuery or CommandPreparedStatementUpdate.

For outdated servers that don't send the field, the driver maintains its current behavior of using CommandPreparedStatementQuery when the dataset_schema is not empty, thus ensuring the backward compatibility of the new driver with old servers.

This change was created with AI assistance (Augment Code and Claude code). All lines were manually reviewed by a human. The output is not copyrightable subject matter.


What's Changed

Please fill in a description of the changes here.

This contains breaking changes.

Closes #NNN.

…sult (apache#1064)

## What's Changed

A new field, `optional bool is_update = 4;`, was added to `message
ActionCreatePreparedStatementResult`. When this field is sent by the
server, its value indicates whether the proper network flow to execute
the query that the driver should follow uses
`CommandPreparedStatementQuery` or `CommandPreparedStatementUpdate`.


For outdated servers that don't send the field, the driver maintains its
current behavior of using `CommandPreparedStatementQuery` when the
`dataset_schema` is not empty, thus ensuring the backward compatibility
of the new driver with old servers.

This change was created with AI assistance (Augment Code and Claude
code). All lines were manually reviewed by a human. The output is not
copyrightable subject matter.

- Closes apache#1063

---------

Co-authored-by: David Li <li.davidm96@gmail.com>
@github-actions

This comment has been minimized.

@ennuite ennuite left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is correct (it's a clean cherry pick).
Regarding the labels: this is not a breaking change (backwards compatibility is preserved), and the proper label is enhancement. I went ahead and edited the labels myself.

@ennuite ennuite added enhancement New feature or request and removed breaking-change labels Aug 18, 2026
@lriggs
lriggs merged commit 7c673d7 into dremio:dremio_27.0_23_19 Aug 18, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants