Use actual menu name to log to datadog - #1794
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1794 +/- ##
============================================
- Coverage 70.12% 70.11% -0.02%
- Complexity 2028 2029 +1
============================================
Files 257 257
Lines 8004 8008 +4
Branches 762 762
============================================
+ Hits 5613 5615 +2
- Misses 2108 2110 +2
Partials 283 283 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MartinRiese
marked this pull request as ready for review
August 5, 2026 12:13
esoergel
approved these changes
Aug 5, 2026
1 task
esoergel
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
In addition to the menu name getBestTitle returns the command value for case search which is misleading for logging the moduleName (menu) to datadog and in some cases like BHA groups together modules that are distinct. Use the new getMenuTitle instead (added in dimagi/commcare-core#1549). Also add the menuTitle to the navigate_menu response so it can be used for google analytics logging.
Technical Summary
https://dimagi.atlassian.net/browse/USH-6605
Safety Assurance
Safety story
Tested locally.
Automated test coverage
QA Plan
Special deploy instructions
Rollback instructions
Review