Skip to content

Use actual menu name to log to datadog - #1794

Merged
MartinRiese merged 3 commits into
masterfrom
riese/menuname_for_datadog
Aug 10, 2026
Merged

Use actual menu name to log to datadog#1794
MartinRiese merged 3 commits into
masterfrom
riese/menuname_for_datadog

Conversation

@MartinRiese

@MartinRiese MartinRiese commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Product Description

In addition to the menu name getBestTitle returns the command value for case search which is misleading for logging the moduleName (menu) to datadog and in some cases like BHA groups together modules that are distinct. Use the new getMenuTitle instead (added in dimagi/commcare-core#1549). Also add the menuTitle to the navigate_menu response so it can be used for google analytics logging.

Technical Summary

https://dimagi.atlassian.net/browse/USH-6605

Safety Assurance

Safety story

Tested locally.

Automated test coverage

QA Plan

Special deploy instructions

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.11%. Comparing base (ef9096c) to head (72ec366).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1794      +/-   ##
============================================
- Coverage     70.12%   70.11%   -0.02%     
- Complexity     2028     2029       +1     
============================================
  Files           257      257              
  Lines          8004     8008       +4     
  Branches        762      762              
============================================
+ Hits           5613     5615       +2     
- Misses         2108     2110       +2     
  Partials        283      283              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MartinRiese
MartinRiese marked this pull request as ready for review August 5, 2026 12:13
@MartinRiese
MartinRiese enabled auto-merge August 10, 2026 15:36
@MartinRiese
MartinRiese merged commit 372832b into master Aug 10, 2026
3 of 4 checks passed
@MartinRiese
MartinRiese deleted the riese/menuname_for_datadog branch August 10, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants