Repository navigation
feat: expose March-Dollase preferred-orientation correction - #119
Merged
Merged
Conversation
Bind TextureMarchDollase in powderpatterndiffraction_ext.cpp and add PowderPatternDiffraction.GetTextureMarchDollase, which finds the component's texture object in its sub-object registry because ObjCryst++ has no public accessor. SetPhasePar sets values through the phase's RefinablePars, since ObjCryst++'s SetPhasePar does not click the texture clock and leaves the cached pattern stale. DeletePhase is not bound because libObjCryst does not define it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
I'm opening this PR because this is a feature I want exposed for a package I am working on |
Contributor
|
This LGTM. |
Collaborator
|
Looks good - the workaround for the texture cache should ideally be fixed first in objcryst, but we can accept the proposed workaround in the meantime. |
Contributor
Author
|
@vincefn Thanks. Should we make an issue here to change this workaround when fixed in objcryst? |
2 tasks done
vincefn
added a commit
that referenced
this pull request
Nov 3, 2026
…obind (#122) * feat: port March-Dollase texture (#119) and TOF profile (#120) to nanobind - Bind TextureMarchDollase and PowderPatternDiffraction.GetTextureMarchDollase. SetPhasePar is bound directly (no RefinablePar workaround) since the objcryst submodule (ba6ca89, vincefn/objcryst#105) now clicks the texture clock; DeletePhase is also exposed. - TextureMarchDollase has RefinableObj as a second (non-zero offset) base, so it is registered standalone with bind_refinableobj_forwarding and added to extractRefinableObjArg. - Bind ReflectionProfileDoubleExponentialPseudoVoigt; SetProfile gives a TOF profile copy the crystal's unit cell. - Port tests and news items, with extra DeletePhase tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit hooks * ci: check out submodules and exclude vendored extern/ from pre-commit - Pass submodules: 'true' to the scikit-package reusable workflows, so that extern/objcryst is available when building. - Exclude extern/ (objcryst submodule, vendored cctbx and newmat) from pre-commit hooks. - Remove duplicated test_lsq_compiled_refined_obj_erase_all_param_set (F811) and fix a typo flagged by codespell. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit hooks * [pre-commit.ci] auto fixes from pre-commit hooks * docs: keep inline code on one line so prettier output is stable Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * revert: restore vendored extern/ sources modified by pre-commit.ci autofix Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #118
Bind TextureMarchDollase in powderpatterndiffraction_ext.cpp and add PowderPatternDiffraction.GetTextureMarchDollase, which finds the component's texture object in its sub-object registry because ObjCryst++ has no public accessor. SetPhasePar sets values through the phase's RefinablePars, since ObjCryst++'s SetPhasePar does not click the texture clock and leaves the cached pattern stale. DeletePhase is not bound because libObjCryst does not define it.