Skip to content

feat: add Component targets and settings - #7

Merged
sbillinge merged 3 commits into
diffpy:mainfrom
cadenmyers13:component-targets-and-settings
Oct 30, 2026
Merged

sbillinge merged 3 commits into
diffpy:mainfrom
cadenmyers13:component-targets-and-settings

Conversation

@cadenmyers13

Copy link
Copy Markdown
Contributor

These functions are mostly internal and would not be used in refinement

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

@sbillinge

Copy link
Copy Markdown
Contributor

This looks good. It is failing tests though

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge none of the test will pass as the code is dependent on the pyobjcryst main branch.

@sbillinge
sbillinge merged commit bfcd318 into diffpy:main Oct 30, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants