Repository navigation
refactor: rename profiles module to peak_profiles - #10
Merged
Merged
Conversation
Avoid confusion with srfit's Profile. Renames profiles.py and test_profiles.py and updates the API docs. The module is unreleased, so no deprecation shim is added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@sbillinge ready for review |
Contributor
|
failing tests and conflicted. I merged the pin to objcryst main. Is that work needed here? In that case you could merge main into this branch. |
Contributor
Author
|
@sbillinge All good now. Ready for merge. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 5 5
Lines 535 535
=======================================
Hits 524 524
Misses 11 11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid confusion with srfit's
Profile, I renamedprofiles.pytopeak_profiles.py