Repository navigation
feat: accept a name matching the ParameterSet's own in set_structure - #21
Open
cadenmyers13 wants to merge 1 commit into
Open
cadenmyers13 wants to merge 1 commit into
cadenmyers13 wants to merge 1 commit into
Conversation
set_structure in basepdfgenerator.py raised for any name given with a ParameterSet. It now raises only for a different name, so it behaves like diffpy.cmirietveld's set_structure and every generator is set up the same way. Adds a matching-name case to test_set_structure_with_parameter_set and renames the error test to test_set_structure_with_parameter_set_and_other_name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 6 6
Lines 373 373
=======================================
Hits 363 363
Misses 10 10
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_structure in basepdfgenerator.py raised for any name given with a ParameterSet. It now raises only for a different name. Adds a matching-name case to test_set_structure_with_parameter_set and renames the error test to test_set_structure_with_parameter_set_and_other_name.