Skip to content

fix: create new constraint variables in each solve - #53

Merged
sbillinge merged 2 commits into
diffpy:mainfrom
ycexiao:constraint-var
Oct 26, 2026
Merged

sbillinge merged 2 commits into
diffpy:mainfrom
ycexiao:constraint-var

Conversation

@ycexiao

@ycexiao ycexiao commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What problem does this PR address?

Constraint variables are created to hold the common values used by the variables to be constrained.

e.g. lattice can be created to constrain lattice.a, lattice.b, lattice.c to be the same value of lattice.

Create new constraint variables in each solve so recipe get clean setup.

What should the reviewer(s) do?

@ycexiao ycexiao changed the title fix: update the constraint variable in each solve fix: create new constraint variables in each solve Oct 26, 2026
@ycexiao

ycexiao commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, it's ready for review.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (0c7ccf8) to head (32ce3e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   99.68%   99.69%           
=======================================
  Files           8        8           
  Lines         634      648   +14     
=======================================
+ Hits          632      646   +14     
  Misses          2        2           
Files with missing lines Coverage Δ
tests/test_refinement_session.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
sbillinge merged commit 7dc26dd into diffpy:main Oct 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants