Repository navigation
fix: share neutral inset focus defaults across DDS fields - #122
Merged
Merged
Conversation
jlc488
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared DDS form controls now use neutral focus colors (#52606d light, #b0bbc4 dark) and a 2px inset focus outline. Invalid fields retain their 1px error border using a -3px offset; composite controls keep a single wrapper outline. Calendar popup focus uses the same semantic token. Field APIs and keyboard behavior stay unchanged.
Tokens, common CSS, bilingual design specs and previews are updated, with a patch changeset for the fixed public package group. Screenshots, DOM metrics and scope limits are recorded in docs/qa/focus-defaults-20261025/README.ko.md.
Validation: token generation/parity, CSS generation/contracts, docs sync and diff whitespace checks passed. Manual source Solid fixture and generated CSS preview checks covered normal/composite/invalid fields in the documented states, including light/dark error borders.
The initial CI run (40106128250, head baff332) failed because the Svelte release dry-run rejected already-published version 0.29.1. The Svelte verifier now mirrors the existing Vue gate: only that exact registry collision is recognized; all other errors and packed-file/fresh SSR/client consumer checks remain mandatory. The targeted verify:svelte:release completed successfully after explicitly reporting the expected duplicate-version collision. The original failure and correction are preserved in the QA record. Full CI on the updated head is required before merge and the normal Changesets publication flow.