Repository navigation
refactor(teams_selection): centralize team selection in TeamSelectionService - #592
Open
sawankshrma wants to merge 6 commits into
Open
sawankshrma wants to merge 6 commits into
sawankshrma wants to merge 6 commits into
Conversation
|
This PR has been automatically marked as |
Collaborator
|
Hi, what is the status? |
- add move up/down buttons in selectable list edit mode - track team renames explicitly so reordering isn't treated as a rename - show teams in configured order in heatmap and team selection component
sawankshrma
force-pushed
the
global_team_selection
branch
from
October 26, 2026 09:52
51bc7ca to
0ae4a2e
Compare
Collaborator
Author
Hi @wurstbrot, @vbakke, This PR is now ready to review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
TeamSelectionServiceas the single source of truth for the active team filter, used by the heatmap, report page/modal, and evidence components. RemovesselectedTeamsfromReportConfig(previously stored insidelocalStorage, now only persists per-session)Changes:
selectedTeams,effectiveTeams,selectedGroupName, andisAllSelectedas computed signals.effect()selectAllTeams()/deselectAllTeams()/selectGroup()just emit rather than mutate local state.Follow-up changes: (Addersing Issue: #588)
Teams & Groups can now be reordered with up/down controls in edit mode. Team order is stored in the existing teams array; group order is preserved by rebuilding the group mapping in the selected order.
Team rename handling now tracks explicit rename actions instead of inferring renames from list positions. This prevents a reorder from being treated as a rename and incorrectly moving progress or evidence data.
Deleting a team continues to remove it only from the active team/group configuration; its stored progress and evidence is preserved by re-creating the same team name.