compiler: precompute interp pos/weights - #3000
Open
mloubout wants to merge 1 commit into
Open
Conversation
mloubout
force-pushed
the
cire-int-invariants
branch
from
August 10, 2026 18:29
cda0311 to
f120563
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3000 +/- ##
==========================================
- Coverage 83.54% 82.99% -0.56%
==========================================
Files 257 257
Lines 53922 54018 +96
Branches 4613 4619 +6
==========================================
- Hits 45050 44832 -218
- Misses 8074 8374 +300
- Partials 798 812 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
cire-int-invariants
branch
2 times, most recently
from
August 10, 2026 19:34
e823fb0 to
6f9e7c6
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
force-pushed
the
cire-int-invariants
branch
7 times, most recently
from
August 11, 2026 03:10
da8dee9 to
e4977c2
Compare
| ``coords`` handed in by ``SparseFunction._arg_defaults``. Mirrors | ||
| sinc's `_arg_defaults`: regenerates the tables from the persisted | ||
| shift set, so a pickled/rebuilt interpolator (decoupled workers) | ||
| still emits data for every table the operator was compiled with.""" |
Contributor
There was a problem hiding this comment.
some blank spaces and comments here would help
| tag = _shift_tag(shifts) | ||
| sfname = self.sfunction.name | ||
| sfdim = self.sfunction._sparse_dim | ||
| gp_name = f'{sfname}_gp{tag}' |
Contributor
There was a problem hiding this comment.
maybe some blank lines and comments would help in this function
| else: | ||
| symbols.append(Symbol(name=f'p{d}', dtype=dtype)) | ||
| return DimensionTuple(*symbols, getters=self.grid.dimensions) | ||
| def _tables_for(self, key): |
Contributor
There was a problem hiding this comment.
I'd change the name to emphasize that something is being created, such as _tabulate
| `(gridpoints, coeffs_per_dim)` for that shift set; mirrors sinc's | ||
| `interpolation_coeffs` cached_property but keyed on `shifts`.""" | ||
| self._shifts_used.add(key) | ||
| shifts = list(key) if key else None |
| values = super()._arg_values(estimate_memory=estimate_memory, **kwargs) | ||
| if estimate_memory: | ||
| return values | ||
| onames = [o.name for o in self.grid.origin_symbols] |
| values.update(self.interpolator._arg_defaults( | ||
| coords=coords, sfunc=self, origin=origin | ||
| )) | ||
| return values |
| shifts = list(key) if key else None | ||
| gp, coeffs = self._tables_for(key) | ||
| args[gp.name] = _cell_indices(coords, grid, shifts, spacing, origin) | ||
| for i, w in enumerate(coeffs): |
Contributor
There was a problem hiding this comment.
can probably do with a comprehension but not sure if it actually gets harder to read
mloubout
force-pushed
the
cire-int-invariants
branch
2 times, most recently
from
August 11, 2026 11:30
b8bd51c to
90a9144
Compare
FabioLuporini
approved these changes
Aug 11, 2026
FabioLuporini
approved these changes
Aug 11, 2026
mloubout
force-pushed
the
cire-int-invariants
branch
from
August 11, 2026 16:25
90a9144 to
200302c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.