fix: add clickjacking protection headers - #1195
Open
DevipriyaS17 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
+ Coverage 49.79% 50.26% +0.47%
==========================================
Files 146 146
Lines 13460 13466 +6
==========================================
+ Hits 6702 6769 +67
+ Misses 6177 6108 -69
- Partials 581 589 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds global anti-clickjacking response headers to Console’s Gin HTTP router to prevent UI/API embedding in third-party frames.
Changes:
- Introduced a Gin middleware that sets
X-Frame-Options: SAMEORIGINandContent-Security-Policy: frame-ancestors 'self'on responses. - Added unit tests asserting these headers are present both for a simple route and for the
/api/v1/authorizeroute.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/controller/httpapi/router.go | Adds clickjacking protection middleware and applies it globally to the router. |
| internal/controller/httpapi/ui_test.go | Adds tests validating the middleware and router behavior sets the expected headers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DevipriyaS17
force-pushed
the
clickjacking
branch
from
August 12, 2026 09:26
a2184e6 to
11a050c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR address by adding anti-clickjacking response headers to Console HTTP responses. The change prevents the Console UI and API endpoints from being embedded in third-party frames, reducing risk of UI redress attacks against authenticated sessions.
Issue:
The finding states Console is vulnerable to clickjacking.
Sample Output