Bump to 2.1.0, and point the banner at the release - #341
Merged
Conversation
Release checklist step 1: VERSION and CITATION.cff's version field, which nothing checks against each other, so they are easy to let drift. The homepage banner led with 2.0 compatibility and sent reports to the pinned migration issue. It leads with what 2.1 does now, and points at the tracker rather than one thread; #284 served the 2.0 migration and is closed. The release log still says Unreleased. Stamping a date before the tag exists risks a wrong one if the merge slips, so that is the tag-time step.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 41 41
Lines 2845 2845
=======================================
Hits 2802 2802
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Checklist step 2. Matches the existing format (no leading zero on the day, as in 1.3.0 - July 5, 2026). This assumes the tag lands today. If it slips, this line is the one to correct.
2.0 is still recent enough to lead with; the earlier version demoted it to a compatibility footnote. The megaphone stays on 2.0, and the East Asian note follows as its own paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release checklist step 1, plus the homepage banner.
nameparser/_version.pyVERSION = (2, 1, 0);PRE_RELEASEstays""(no rc)CITATION.cffversion: "2.1.0"README.rstCITATION.cffis the one the checklist calls out and nothing enforces: no test compares it to_version.py, so it drifts silently. Verified equal here.The banner
Was leading with 2.0 compatibility and routing reports to the pinned migration issue:
Now leads with what the release does, and sends people to the tracker:
Two paragraphs so the 2.1 news leads and the 2.0 compatibility note stands on its own. The
#east-asian-namesanchor was verified present in the builtusage.html. #284 is closed, having served the 2.0 migration.What this PR deliberately does NOT do
docs/release_log.rststill says* 2.1.0 - Unreleased. Stamping a date before the tag exists means a wrong date if the merge slips past midnight, so that stays a tag-time step. Say the word if you'd rather have it here and I'll add it.Verification
import nameparser→__version__2.1.0,VERSION(2, 1, 0); matchesCITATION.cffpython -m build --sdist→ buildsnameparser-2.1.0.tar.gz;twine checkPASSEDpython -m doctest README.rst→ 16 passpytest3065 passed;mypyandruffclean; Sphinx HTML 0 warnings--baseline 1.4.0107/0,--baseline 2.0.089 diffs / 0 unexplained / 0 Latin-onlyOne nice side effect of the bump: the gate's
tree:line now reads 2.1.0 against a 2.0.0 baseline, so_check_tell's version half has real signal for that baseline instead of relying on the path check alone.🤖 Generated with Claude Code