Repository navigation
Add a deploy-form button that provisions a registry pull secret - #347
Merged
Merged
Conversation
New creates a registry-pull service account, a role with only registry.pull, and a pull secret for registry.deploys.app in the selected location. A same-project image preselects that secret when the field is empty and the location list already contains it. Prompter: ACS
|
Preview deleted (PR closed). |
New stays off the form when registry-pull is already in that location. Prompter: ACS
The sentence describes the New button, so it follows the same gate: it stays hidden until the pull-secret list has settled, and it stays hidden when registry-pull is already in the selected location. Prompter: ACS
serviceAccount.create reports a taken sid as "api: sid not available". New reads that account's roles and continues with it when they are empty or only registry-pull, and when that role is limited to registry.pull. Any other binding stops in an error modal and does not call role.bind. Prompter: ACS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry-pullservice account, a role whose only permission isregistry.pull, and a pull secret forhttps://registry.deploys.appin the selected location.registry-pullis already in that location, and so does the "For a private registry..." helper.registry-pull, and that role is limited toregistry.pull. Any other binding opens an error modal and leaves the account's roles unchanged.role.bindis not called in that case.registry.deploys.app/<project>/...image preselectsregistry-pullonly when that secret is already in the loaded list and the field is empty.role.createwhen theregistry-pullrole does not already exist. A missing grant shows a disabled button whose tooltip names the first missing permission.registry-pullalready in the location — the field is there, New is not, and the helper is hidden:The existing account is bound to another role, so New stops:
Test plan
bun lintbun checkbunx playwright test tests/deploy-registry-pull.spec.js --retries=0(22 passed)Requested via Grok Work
Prompter: ACS
Session: 0d6e6161-ea08-44d8-898f-0cbd9be7838c