fix(ext/http): route invalid async responses to onError - #36437
Open
subotac wants to merge 1 commit into
Open
Conversation
Deno Individual Contributor License AgreementThe following contributors need to sign the CLA before this PR can be merged: Click here to review and sign the CLA | Re-run CLA check This is an automated message from CLA Assistant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36425.
Invalid values returned asynchronously from
Deno.servehandlers were validated inside a promise fulfillment callback, after the rejection handler had already been attached to the original handler promise. Theresulting
TypeErrortherefore bypassedonError.Attach error handling after response conversion and fall back to the internal 500 response if an asynchronous
onErrorresult also fails. Extend the existing serve callback test to cover both synchronous andasynchronously resolved invalid values.
Tests:
cargo test -p unit_tests --test unit -- handleServeCallbackReturncargo test -p unit_tests --test unit -- serve