Repository navigation
ass: keep the areas of its allocator aligned for the host - #391
Merged
Merged
Conversation
maarten-boot
commented
Nov 3, 2026
Contributor
getarea() rounds sizes to sizeof(int) and splits free blocks from the end, so after a name (strlen + 1 bytes) the next area is at 4 (mod 8), and the structs kept there (line_t, relc_t, locl_t, stat_t and the allocator's own freeblock, all with pointers) are misaligned on a 64-bit host: -fsanitize=alignment reports 919 accesses in em_ass when the em22 examples are linked. Round all sizes to _Alignof(max_align_t), and to at least the size of a free block's header, as led does since its alignment fix; align the workspace in main()'s frame that is given to the allocator at start. em_ass's output is unchanged (the seven em22 examples are identical). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Merging, thanks (although I think I'll just rip out the custom allocator here; they're usually a terrible idea). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.