Repository navigation
Address PR feedback for v4 - #380
Merged
Merged
Conversation
added 2 commits
October 27, 2026 11:10
…OS, fix the exclude-subdomain key, and stop skipping TSK-prefixed delegates
…d refresh the Info.plist screenshot
NSExceptional
approved these changes
Oct 27, 2026
uroboro
approved these changes
Oct 28, 2026
Co-authored-by: uroboro <uroboro845@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a repo audit and from review feedback on #378.
Behavior changes
TSKExpirationDatenow throws. A value that wasn't ayyyy-MM-ddstring used to be dropped, so the pins never expired. It now raises the same "TrustKit configuration invalid" exception as other config errors.TSKExcludeSubdomainFromParentPolicyworks in Info.plist. The constant's value was misspelled askSKExcludeSubdomainFromParentPolicy, so the documented key was ignored. The app then failed at launch with the "less than 2 pins" error. Code that useskTSKExcludeSubdomainFromParentPolicyis unaffected. An Info.plist that uses the misspelled string must be renamed.TSKIgnorePinningForUserDefinedTrustAnchorsisNO. These are now handled like any other pin mismatch: the connection is blocked only whenTSKEnforcePinningisYES, and a report is sent either way. Before, they were always blocked and never reported.TSK. The check now matches TrustKit's own classes:TSKBackgroundReporterandTSKNSURLSessionDelegateProxyfor sessions, andTSKNSURLConnectionDelegateProxyfor connections. The proxy c being wrapped twice when the swizzle is installed more than once, as the tests do.Cleanup
+[TSKPinningValidator allowsAdditionalTrustAnchors]and its unused test subclass. Nothing has called this since anchors were removed in document limitations of TSKAdditionalTrustAnchors on iOS 11 #154.It never fixed the watchOS rmage. watchOS goes back into the test matrix once [macOS] xcode-27-arm64: duplicate watchOS 27.0 runtime actions/runner-images#14946 is fixed.
Docs
app-vendor-idis now documented as a random UUID that TrustKit generates once per install. nce 3.0.1.TSKExpirationDateto the configuration key table inTrustKit.h, and saythat any other value is a co
TSKPublicKeyAlgorithms,with one using the demo app'
Not changed
Tests
TSKis still proxied.