regex XML_COMMENT is buggy, and xml comments are ignored by parser anyway - #656
Merged
Conversation
moritz-gross
changed the title
Removed the static regex for processing instructions and comments. `sxd_parser` handles these and the earlier size limit prevents DOS attacks. All but elements and text children are eliminated from the DOM in `cleanup_mathml`.
Fix the usage of mathml_str in HTML_ENTITIES replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was chatting with Codex about the codebase, and found this.
As far as I can tell, the Regex
XML_COMMENTdoes not work, as it is only an inline modifier inside of a raw Rust string, and additionally removing comments is not needed anyway as we use a parser that ignores it afterwards.@NSoiffer what do you say?