A failed OAuth connect or callback renders an operator page, not JSON - #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /api/oauth/{slug}/connectandGET /api/oauth/callbackare reached by full-page browser navigation — the Settings card opens the connect door in a new tab, and the provider redirects the callback back to it. On success the callback already renders an HTML page. On failure both doors raisedHTTPException, so the operator landed on raw JSON.Both doors now raise a typed
OauthPageErrorthat carries its status. One handler renders it as an operator page in the same chrome as the success page: the message names the fix — an unseturls.endpoint, client credentials that are not connected yet, a denied consent — and the real status code is kept. The JSON API routes on the same router are unchanged, so afetchstill gets the JSON envelope.The scope is kept small. When the flow carries a
next, a bounce back to it with an?oauth_errorquery is left out until a caller navigates the connect door withnext; nothing does today.