A service's slug derives from its class name - #303
Merged
Conversation
czpython
force-pushed
the
service-slug-derives
branch
3 times, most recently
from
August 22, 2026 09:51
5350d71 to
49eadcb
Compare
czpython
enabled auto-merge (squash)
August 22, 2026 09:53
czpython
force-pushed
the
service-slug-derives
branch
from
August 22, 2026 09:55
49eadcb to
345df66
Compare
czpython
force-pushed
the
service-slug-derives
branch
from
August 22, 2026 09:56
345df66 to
873b3ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service.nameis nowService.slug, and nobody declares it: the slug derives from the class name (Gmail→gmail,GoogleCalendar→google_calendar), and the card heading derives from the slug. A minimal service is a class name and aSettingsmodel:slug = "..."stays as the escape route — set it only to keep a key the class name does not spell, because the slug keys theservice_identitiesrow and the connect wire: renaming a class without pinning its slug rekeys the card and orphans the connected identity. The docs say exactly that.Every derived slug matches the string its row already uses (
GitHubAppis renamedGithubto keep"github"), so existing installs are untouched — no migration.The contract stays loud: declaring
nameraises with the migration hint, declaringtitleraises, an abstract base that pins aslugraises, and an explicit slug is still validated against the key pattern. The stray-capability probe in doctor now also skips abstract service bases instead of tripping on their missing key.Wire and mirror move together:
ServiceResponse.name→slug, the frontendServicetype, SettingsModal, and the oauth-callback broadcast page follow in the same commit. Path values are unchanged —/api/services/gmailand/api/oauth/gmail/connectread as before.