Repository navigation
Prevent opening the same module twice - #439
Merged
Merged
Conversation
Opening a module that is already open created a second copy that shared the same .mod file. Both copies wrote their settings on exit, so the last one saved won, and both names were stored in OPEN_MODULES. The duplicate was then restored on every start. Two copies of a module also meant two map views, which is how the crash when closing one of several map views was found. That crash is fixed separately by "Fix crash when closing one of several map views". When a module that is already open is selected in File > Open, bring it to the front instead of opening a second copy. When restoring the open modules on startup, skip names that appear more than once, so existing configs with duplicates are repaired.
Owner
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a module that is already open created a second copy that shared the same .mod file. Both copies wrote their settings on exit, so the last one saved won, and both names were stored in OPEN_MODULES in the gpredict.cfg file. The duplicate was then restored on every start.
Two copies of a module also meant two map views, which is how the crash when closing one of several map views was found. That crash is fixed separately by #438 "Fix crash when closing one of several map views".
When a module that is already open is selected in File > Open, bring it to the front instead of opening a second copy. When restoring the open modules on startup, skip names that appear more than once, so existing configs with duplicates are repaired.