Repository navigation
feat: add the committed-artifacts check: no build outputs are committed - #119
Merged
Merged
Conversation
BuildOutputs gains `artifacts`, globs for the outputs each ecosystem must never commit, so every profile gets both vcs-ignore and committed-artifacts from one rule. A file inside an output directory is reported as the outermost such directory. In a git checkout only tracked files are judged. Each bare fixture now commits an output, so it fails the new practice. Closes #56 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 98.35% 98.37% +0.01%
==========================================
Files 53 54 +1
Lines 2069 2092 +23
Branches 205 208 +3
==========================================
+ Hits 2035 2058 +23
Misses 28 28
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56. Phase 3 of #107.
BuildOutputsgainsartifacts, the globs for the outputs each ecosystem must never commit, so every profile gets bothvcs-ignoreandcommitted-artifactsfrom one rule./names a directory anywhere, and one that also starts with/names a directory at the top of the project.build/.--excludeapplies.main.o,dist/,target/,coverage.out), so it fails the new practice.This repository passes.
🤖 Generated with Claude Code