Repository navigation
fix(transport): clamp retry_delay to zero for past Retry-After timestamps - #98
Open
Adityakk9031 wants to merge 1 commit into
Open
Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server returns a
Retry-Afterheader as an HTTP date that has already passed (or is in the past due to slight clock drift or caching),Time.httpdate(_1) - Time.nowevaluates to a negative number.Because Ruby treats negative floats as truthy,
retry_delayreturned the negative value straight intosleep(delay), throwing anArgumentError: time interval must not be negativeand aborting the retry cycle.This clamps the parsed span to
[span, 0.0].maxso past timestamps or negative retry headers cleanly back off for 0 seconds instead of crashing. Added a test case inclient_test.rb.