fix(graphqlTS): surface real error detail instead of a generic schema error - #199
Merged
Conversation
… error Non-schema GraphQL failures (plain HTTP errors, top-level GraphQL errors, REST-style error_message bodies) were collapsing into the generic GRAPHQL_SCHEMA_ERROR because only one specific error shape was checked. Fall back through the other known shapes, then to the HTTP status and request URL, so callers get something to diagnose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Coverage report for commit: fe245c8 Summary - Lines: 79.29% | Methods: 75.89% | Branches: 61.76%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
cs-raj
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-schema GraphQL failures (plain HTTP errors, top-level GraphQL errors, REST-style
error_messagebodies) were collapsing into the genericGRAPHQL_SCHEMA_ERRORbecause only one specific error shape was checked. Falls back through the other known shapes, then to HTTP status + request URL, so callers get something to diagnose.Recreated against the new
developmentbranch (olddevelopment/mainhistory was out of sync —developmentwas recreated frommainand this is a fresh commit, replacing closed PR #198).Test plan
tests/unit/graphqlTS/graphqlTS.test.ts— 10/10 passing, including 3 new regression cases