Repository navigation
Conversation
Auto-generated by schema-propagation workflow. Source: constructive-db@63c6d726a89
|
Review complete. 🟡 2 medium 💬 Inline comments (1)
📍 Findings outside the diff (1) — 🟡 1 medium — defects on lines GitHub can't attach comments to🟡 Medium — Remove The regenerated SDKs delete the hooks 🧹 Nitpicks (5) — 🟢 5 low
This is a coordinated schema-and-clients regeneration commit: the per-domain
The removals are breaking for external consumers of the published SDK surface, and two regenerated CLI commands ( Reviewed commit: 22038e6 |
There was a problem hiding this comment.
Regenerates all GraphQL schemas and SDK clients (constructive-sdk, constructive-cli, constructive-react) to reflect backend changes: builder-binding rename to service-binding, new PlatformReservedSubdomain CRUD, exchangeNativeHandoff and signInOptions auth surface, and enriched Meta* schema introspection.
Key findings
- 🟡 Remove
resolve*/apiSchemaNames/dbnameAPI surface — index.ts - 🟡 New CLI commands exit 0 on API errors — exchange-native-handoff.ts:44
| .execute(); | ||
| console.log(JSON.stringify(result, null, 2)); |
There was a problem hiding this comment.
🟡 bug · medium
New CLI commands exit 0 on API errors
The newly generated CLI commands call .execute(), which resolves with { ok: false, errors } instead of throwing when the server returns GraphQL or HTTP errors (sdk/constructive-sdk/src/auth/orm/client.ts:64), then print the raw JSON and fall through to exit code 0 (sdk/constructive-cli/src/auth/cli/commands/exchange-native-handoff.ts:44). Scripts and CI invoking csdk cannot detect failures: a failed sign-in-options query or exchangeNativeHandoff mutation is reported as success. The same pattern appears in sdk/constructive-cli/src/auth/cli/commands/sign-in-options.ts at line 28.
📋 Prompt for AI Agents
In the newly generated CLI commands (sdk/constructive-cli/src/auth/cli/commands/exchange-native-handoff.ts lines 44-45 and sign-in-options.ts lines 28-29, plus any other new commands sharing the pattern), execute() returns { ok, data, errors } and never throws on GraphQL errors, so the commands exit 0 even when the API call failed. After awaiting execute(), add: if (!result.ok) { console.error(result.errors); process.exit(1); } before printing the result, so scripts can detect failures via exit code. Since the files are generated, apply the fix in the @constructive-io/graphql-codegen CLI command template.
Automated Schema + SDK Update
This PR was created by the schema-propagation workflow.
What changed
Updated schema files from constructive-db and regenerated ALL SDK clients.
Source:
constructive-db@63c6d726a89Schemas updated
sdk/constructive-sdk/schemas/— all API targets from constructive-db (auto-discovered)sdk/migrate-client/schemas/— migratepgpm/export/src/meta-export-tables.json— generated meta export table listClients regenerated
sdk/constructive-sdk/src/— ORM clientsdk/constructive-cli/src/— CLI clientsdk/constructive-react/src/— React hookssdk/migrate-client/src/— Migrate clientSkill references updated
.agents/skills/— Generated skill documentationAuto-generated by constructive-hub schema-propagation