Use the shared release-drafter config instead of a local copy - #333
Merged
Conversation
plexus-utils carried a full duplicate of the org release-drafter config. It had drifted: five categories (Removed, Deprecated, Documentation, Build, and the Removed title) used the singular `label:` key, which release-drafter does not honour, so those categories never matched anything. Replace the copy with `_extends` and keep only the three plexus-utils specifics: the tag template, the version scheme and filter-by-commitish for the parallel 3.x release line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #58, companion to codehaus-plexus/.github#64.
plexus-utilsis the only repo in the org carrying a full copy of the release-drafter configuration instead of extending the shared one. Every other repo uses_extends. This replaces the copy with_extendsplus the three things that are genuinely specific toplexus-utils:tag-template: plexus-utils-$NEXT_PATCH_VERSION— the org default is a bare versionversion-template: $MAJOR.$MINOR.$PATCHfilter-by-commitish: true— this repo releases from bothmasterandplexus-utils-3.x, so a draft must only collect commits from the branch being released. Losing this would mix the two lines together, which is why it is kept and now carries a comment explaining why._extendsmerges at the top level, so those three keys override the shared file cleanly. The one thing to know for the future:categoriesis an array, and overriding it replaces the whole array rather than appending — so a future plexus-utils-only category would mean reinstating a full localcategoriesblock. Nothing here needs that.Net effect: 59 lines of duplication removed, and the config stops drifting away from the org default on its own.
Correction to an earlier version of this description. I originally claimed the local copy had a bug — that its five categories using the singular
label:key (Removed, Deprecated, Documentation, Build, Tests) never matched anything. That is wrong and I've removed it. Release-drafter acceptslabel:as documented shorthand for a singlelabels:entry —schema.jsonat v7.7.0 declares it as a valid category property, and the README states it plainly:Those categories have been working the whole time. This PR is deduplication, not a bug fix. Thanks to the reviewer who caught it.