Add the Publish Site workflow - #23
Merged
Merged
Conversation
Calls the shared workflow from codehaus-plexus/.github#62, so the organisation site can be published from the Actions tab rather than by a maintainer running 'mvn site-deploy' locally. This site is served from the master branch, not gh-pages, because it is an organisation page. That target comes from scmBranch in this POM; the shared workflow leaves the branch to the POM rather than forcing gh-pages, which is codehaus-plexus/.github#65. Part of codehaus-plexus/.github#58
Member
Author
|
Updated: now passes The dry run you triggered failed, and usefully — it showed the whole authentication approach was broken, not just the branch:
codehaus-plexus/.github#66 fixes it by pushing with git directly. Merge that first, then this is ready for another dry run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of codehaus-plexus/.github#58. Calls the shared workflow from codehaus-plexus/.github#62, so this site can be published from the Actions tab instead of by someone running
mvn site-deployon their laptop.This repository is the odd one out
Every other site in the organisation is a project page served from
gh-pages. This is the organisation page, and it is served frommaster:The POM already knows that:
But the shared workflow as merged forces
-Dscmpublish.scm.branch=gh-pages, which would have overridden it and pushed this site to a branch nobody serves. The build would have reported success; the only symptom would have been the site quietly never updating.codehaus-plexus/.github#65 removes that override so the branch comes from the POM, which is where it was already correct. That is my bug from #62 — I generalised from the fourteen project sites without checking the org page. Adding this caller is what surfaced it.
The caller itself
Identical to the single-module form in codehaus-plexus/plexus-utils#334, with a comment recording why this one is different so the next person does not have to rediscover it. No
multi-moduleinput: this is a single-module build withcontentset totarget/site.Please dry-run it first
The workflow exposes
dry-run, which builds the site and checks out the target branch without committing. Worth using here more than anywhere else, since a mistake publishes to the front page of the organisation.I have not run it. Note also that a real run will republish the site from current
source, which includes the pages converted to Markdown in #22 — so it would be worth having that reviewed first if you want the two changes to land separately.