Repository navigation
fix: separate confirmation from action labels - #498
Conversation
commit: |
|
LGTM |
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 263.9 ms | 7.0 ms | 255.4 ms | 278.6 ms |
| base | 268.1 ms | 9.4 ms | 257.5 ms | 292.5 ms |
Δ (PR vs base): ↓ -4.2 ms (-1.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
There was a problem hiding this comment.
✅ Approved — No findings: the label derivation and the earlier required-body check are correct, and the generated output, tests, docs and changeset are consistent with them.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🚀 Release: ✅ LGTM
Risk: low. A patch changeset is appropriate for this fix.
🔒 Security: ✅ LGTM
The confirmation and --force behaviour is unchanged. The missing-body check now runs before authentication, which adds no exposure.
📖 AGENTS.md: ✅ LGTM
The change follows the repository conventions: generated output was regenerated rather than edited by hand, labels are derived from the HTTP method, and a changeset is included.
📋 Code Quality: ✅ LGTM
The generator changes are small and well tested. The required-body check moved from plainCall to the start of the handler, and it now covers file and multipart inputs.
⚡ Performance: ✅ LGTM
No performance impact.
📝 Documentation: ✅ LGTM
The architecture reference has been updated to describe the new label behaviour.
Reviewed commit: 5123bae3
Commands marked with
x-forge-require-confirmationcurrently inherit Deleting/Deleted labels even when they update settings, restore data, or process a mixed batch. Generate action labels from the finalized HTTP method: Updating/Updated for PUT/PATCH, Deleting/Deleted for DELETE, and neutral Processing/Done for confirmed POST actions. Keep read and validation labels, operation-specific warnings, and--forcebehavior.Check for missing required
--bodyinput before authentication and confirmation, while accepting file and multipart inputs. Regenerate the tracked commands, update the architecture reference, and add a patch changeset.Validation:
pnpm checkpnpm test src/__tests__/generator/pluginfrompackages/clipnpm test src/__tests__/generator/plugin/multipart-files.test.tsfrompackages/cliafter adding upload regression coverageAddresses the generator findings in the review on #477.