Skip to content

fix: write each SPOP frame with a single socket write #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
Aug 14, 2026
Merged

fix: write each SPOP frame with a single socket write #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions haproxyspoa/spoa_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,10 @@ async def write_frame(self, writer: asyncio.StreamWriter):
frame_payload_bytes = self.payload.getvalue()
frame_length = len(frame_header_bytes) + len(frame_payload_bytes)

writer.write(frame_length.to_bytes(4, byteorder='big'))
writer.write(frame_header_bytes)
writer.write(frame_payload_bytes)
# Emit the whole frame in a single write so it leaves as one TCP segment
# whenever it fits: HAProxy 3.2+ (rewritten SPOP mux) intermittently resets
# connections whose AGENT-HELLO arrives split across several segments.
writer.write(frame_length.to_bytes(4, byteorder='big') + frame_header_bytes + frame_payload_bytes)
await writer.drain()


Expand Down