Repository navigation
knowledge: Prometheus exposition parsing in test helpers (1 insight) - #318
Open
choiyounggi wants to merge 1 commit into
Open
choiyounggi wants to merge 1 commit into
choiyounggi wants to merge 1 commit into
Conversation
Contributor
Wiki agent gate: failPR #318 adds one page, wiki/testing/quality/prometheus-exposition-parsing-in-test-helpers.md, plus an index row, a back-link and a log entry. The page is general and not duplicated. It fails on one fact check: the page cites a claim that its source does not contain. The claim is that the client_python parser is "more lenient than the Go reference parser". Neither the cited parser page nor the project README says it. The other three cited URLs support the claims they are cited for.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowledge flush — 1 insight(s) (headless auto-flush run 20261030-112310-27790)
This run claimed 13 queue rows. Results: 1 ingested, 2 dropped as duplicates of
the merged wiki, 1 released because it plausibly overlaps open knowledge PRs, and
9 released unread because this headless run could not find their queue files.
Nothing was folded into another branch.
Verified best-practice
248ccfddbcc612a1\{([^}]*)\}rejects valid lines once label values contain}(route templates such as/order/{id}). Prefer a real parser. If the helper must stay a regex, match each quoted value as one unit, and keep one negative case showing an unclosed label set is still rejected}is legal inside the quotes. https://prometheus.github.io/client_python/parser documentsprometheus_client.parser.text_string_to_metric_families, and the README notes this parser is more lenient than the Go one. https://www.robustperception.io/openmetrics-is-released confirms the required# EOFline, which backs the OpenMetrics edge row. https://prometheus.io/docs/instrumenting/escaping_schemes/ backs the quoted-UTF-8-names edge row. The session evidence was the line...{route="/order-service/order/{id}",...} 2raising "unparseable exposition line" under the old regex; with the quote-aware regex, 265 tests passed andbroken{a="x" 1still raised. The page's regex was not re-run in this headless run because Bashpython3needs approval here. It is the session's own pattern, wrapped in\{...\}9cce9c1914fef241self.assertXfile asno-assertion: read the floor's Python pattern and treat the result as a false negativebb8b376ef7f0506e.pycbytecode. Use-Bor delete__pycache__python -B" option is not enough on its own:-Bonly stops writing, and an existing stale.pycis still readExisting-layer check
Pages read: testing-quality-assertion-scanner-false-positive-on-unittest-convention, backend-python-language-bytecode-cache-staleness, infrastructure-observability-logs-metrics-signals
Indexes read:
wiki/testing/index.md(full).248ccfddbcc612a1:wiki_searchon Prometheus label parsing returned no page on that trigger. The top hits were config-value escaping, allowlist-regex anchors, and frontmatter quote stripping. A search for Prometheus metrics foundinfrastructure-observability-logs-metrics-signals. That page tells you to label with the route template (/users/{id}), which is exactly the label shape that breaks the naive regex. New pagetesting-quality-prometheus-exposition-parsing-in-test-helpers.related:links to that observability page, which gets a back-link, and totesting-data-adjacent-tokens-in-extractor-fixtures,testing-quality-anchor-cases-for-allowlist-regexesandtesting-quality-tests-that-cannot-fail. No conflict.9cce9c1914fef241:testing-quality-assertion-scanner-false-positive-on-unittest-conventionalready covers it. Its trigger is a floor that greps for bareassert/pytest.raisesand flagsself.assertXfiles. Its step 6 already says to read the classifier and treat the result asfloor=unknown, and a 2026-10-15 field row shows the sametest-floor.shanalyze_pytestmiss. Nothing new, so the row was dropped as a duplicate and retired.bb8b376ef7f0506e:backend-python-language-bytecode-cache-stalenessalready covers the mtime+size validation, purging__pycache__between mutants, re-verifying after the revert, and the row where a delegated auditor mutated the files. It also corrects the candidate on-B. Dropped as a duplicate and retired.Open-PR check
There are 14 open
knowledge/*heads: #317, #315, #310, #309, #308, #307, #306, #305, #304, #301, #300, #299, #298, #293. This headless run has no git access, so it could not diff them. Instead it compared candidates against each PR's changed-file list (gh pr list --json files).248ccfddbcc612a1infrastructure/observability/. #299 editsplatforms/processes/parsing-cli-structured-output.md, which is about CLI tool output, a different trigger. Several PRs touch other rows ofwiki/testing/index.mdonly9cce9c1914fef241assertion-scanner-false-positive-on-unittest-convention.md, but the merged page already holds this rowbb8b376ef7f0506efc76dc4dfa08ecde(Docker-gated schema validator: skip vs fail via aREQUIREenv var, plus a known-bad document)testing/quality/checks-that-cannot-pass.md, and #300 also editstests-that-cannot-fail.md. A validator that is skipped or always says "valid" is that page's core themeRouting decision
248ccfddbcc612a1→testing/quality/prometheus-exposition-parsing-in-test-helpers.md(new page), with a row in thequalitytable ofwiki/testing/index.md. No new category. The lesson is about whether a test's own parsing helper can be trusted, which fitsquality.dataholds fixture-construction pages. The domain hinttestingwas followed. The directive is general: any repo whose tests parse/metrics. The project run appears only in a Sources line.9cce9c1914fef241,bb8b376ef7f0506e→ no edit (duplicates). Rows retired in place withstatus: retired, anoutcome,retiredByandretiredAt.fc76dc4dfa08ecde(open-PR overlap, above). Also1d01cb971e07f6cb,33ffb8688290c9c1,063108972d150963,cb3954d76f244491,fdbac2d18d580e0c,7a851159bdab0e27,ee3362544f6d9162,aa190116f0c2596aand4b0c7878166d1fa8. This run's sandbox blocks listing~/.dev-loop/queue/. Session files can only be found by guessing their session-id names, and those rows sit in files that come after76896825-…in sort order, which could not be found from~/.claude/history.jsonlsession ids. They were released unread for a later manual flush.Local-layer candidates
none