Skip to content

fix(host): make vendor-hermes --silent actually silent #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraenhansen merged 1 commit into from
Aug 12, 2026
+11 −2
Merged

fix(host): make vendor-hermes --silent actually silent #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/silent-vendor-hermes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"react-native-node-api": patch
---

Make `vendor-hermes --silent` actually silent. The spinners were passed
`isEnabled: false`, which stops the animation but still writes the spinner text
and its final symbol to stderr. They now use `isSilent`, which suppresses the
output entirely, leaving the vendored Hermes path on stdout as the command's
only output.
4 changes: 2 additions & 2 deletions packages/host/src/node/cli/hermes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const command = new Command("vendor-hermes")
successText: "Removed existing Hermes clone",
failText: (error) =>
`Failed to remove existing Hermes clone: ${error.message}`,
isEnabled: !silent,
isSilent: silent,
},
);
}
Expand Down Expand Up @@ -123,7 +123,7 @@ export const command = new Command("vendor-hermes")
text: `Cloning Hermes into ${prettyPath(hermesPath)}`,
successText: "Cloned Hermes",
failText: (err) => `Failed to clone Hermes: ${err.message}`,
isEnabled: !silent,
isSilent: silent,
},
);
} catch (error) {
Expand Down
Loading