Repository navigation
Inline a few libcall impls into their raw wrappers regardless of CGU slicing - #14940
Merged
fitzgen merged 1 commit intoOct 22, 2026
Conversation
…slicing Otherwise, changing CGU slicing can change whether these do or don't get inlined in practice, which makes for regressions on host-heavy benchmarks (e.g. benchmarks that spend a bunch of time in GC). Fixes bytecodealliance/are-we-fast-yet#8 See also bytecodealliance/sightglass#348
alexcrichton
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, changing CGU slicing can change whether these do or don't get inlined in practice, which makes for regressions on host-heavy benchmarks (e.g. benchmarks that spend a bunch of time in GC).
Fixes bytecodealliance/are-we-fast-yet#8
See also bytecodealliance/sightglass#348