Add manual dark theme preference support - #62
Merged
Conversation
apex2504
reviewed
Aug 22, 2026
apex2504
reviewed
Aug 22, 2026
apex2504
reviewed
Aug 22, 2026
apex2504
left a comment
apex2504
left a comment
Member
There was a problem hiding this comment.
Nice work! I'd like to hear your thoughts on the best place for the UiModeManager stuff so we can decide where's best for that. But I'm happy with the addition itself. Thanks!
Closed
apex2504
approved these changes
Aug 23, 2026
apex2504
left a comment
apex2504
left a comment
Member
There was a problem hiding this comment.
Tentatively approving, code looks good but I haven't tested myself on the relevant Android versions yet (Android 8, 9+, and 12+). Have you tested these already?
Contributor
Author
|
Besides a Pixel 6a and Pixel 9, I've only tested it on a Pixel 5 running Android 11. |
Contributor
Author
|
Tested on Nexus 6P running Android 8. Works well, and the default dark theme off "migration" is working (and so is the auto option being hidden in settings). |
Member
|
Sweet. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the "Dark theme" option to settings under "Behavior and layout" to manually set the dark theme, continuing #55.
Additionally, since Android 8 and older have no proper system dark mode support, it seems like setting the default value to "off" instead of "auto" would be the move for those versions. The migration code for it is not ideal, but I'm open to other ideas (such as showing the value set to "off" visually, removing the need for the migration)
On Android 11 and lower, the splash screen would follow the system dark theme, regardless of the app dark theme preference. I've spent countless hours looking for a great solution, but to no avail.