[ThomasWaldmann]

Running the test suite on Windows 11 (de-DE, CET, MSYS2 UCRT64, Python 3.14) gave 3 failures that CI (UTC, en-US, no bash >= 4) does not see:

• recreate_cmd_test.py::test_recreate_with_given_timestamp (archiver and binary_archiver): --timestamp 1970-01-02T00:00:00 is converted to local time with datetime.astimezone(). In timezones east of UTC, CPython probes the local offset 24h earlier, which is before the epoch, and Windows' localtime() raises OSError: [Errno 22]. parse_local_timestamp let that escape, so borg crashed with a traceback. In the binary variant, the test harness then also hit a UnicodeDecodeError, because the German Windows error text is cp1252, not UTF-8.
  • parse_local_timestamp now turns that OSError into a ValueError. For --timestamp (create, recreate, prune), argparse then reports invalid timestamp value: '1970-01-02T00:00:00'.
  • The test now uses 1970-01-03, which converts fine.
• completion_cmd_test.py::test_bash_repo_url_no_directories: created directories like ssh:, which is an invalid file name on Windows (WinError 123). The test now creates them from bash instead: MSYS2/Cygwin map the colon to a valid file name character, so the test checks the same thing on Windows. CI skips this test (no bash >= 4), but it runs on a dev box with MSYS2 bash 5. The zsh/fish/tcsh siblings do not create directories.

Also: scripts/msys2-install-deps now installs python-setuptools-scm. This is only needed for pip install --no-build-isolation, where pip does not install the build-system requirements from pyproject.toml. The script already installs the other ones via pacman. Without setuptools-scm, sdist dependencies such as borghash got built as version 0.0.0, and dependency resolution failed. With build isolation (the default, also used by CI), pip installs it into the build environment anyway.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.36%. Comparing base (3c95ce7) to head (5a78cf4).
⚠️ Report is 9 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10535      +/-   ##
==========================================
+ Coverage   89.32%   89.36%   +0.04%     
==========================================
  Files         104      104              
  Lines       20079    20082       +3     
  Branches     3152     3152              
==========================================
+ Hits        17936    17947      +11     
+ Misses       1484     1478       -6     
+ Partials      659      657       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.