Repository navigation
Source: Aws - #603
Open
ekrichbaum wants to merge 26 commits into
Open
Source: Aws#603ekrichbaum wants to merge 26 commits into
ekrichbaum wants to merge 26 commits into
Conversation
Include optional SDK integration, cross-account role assumption, regression tests, and anonymized setup examples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Added account_name configuration for friendly labels in cluster names and updated documentation on instance naming and account handling.
Refactor error handling for VRF creation and add mapping check.
Clarify VRF creation and mapping for VPCs in NetBox integration.
Added resolve_shared_networks method to handle VPC and subnet ownership conflicts. Updated addresses method to include IPv6 networks and modified VPC ownership retrieval logic.
Comment out optional AWS service sync settings in the configuration file.
Updated AWS source description to include S3, Lambda, and EKS.
Refactor AWS source tests to improve tag handling and error management. Update test cases to ensure proper handling of tags and permissions.
Added validation for AWS services and enhanced error handling for S3, Lambda, and EKS resources. Updated methods for syncing AWS resources with NetBox, including improved handling of tags and resource identification.
Added context manager to handle AWS access denial gracefully and updated discovery methods to record denied scopes.
Updated AWS source documentation to reflect optional service discovery for S3, Lambda, and EKS. Clarified permissions and added sections on authorization-denied discovery and troubleshooting.
Expand documentation on authorization failures and resource conflicts in AWS source.
Added AWSAccessCheck dataclass to track access checks and modified AWSClient to record access checks during AWS service calls.
Refactor AWS service tests to improve clarity and functionality. Added new tests for handling conflicts and access tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial working Amazon AWS source integration. Run against large install base across multiple subs in the org. Next phase of this will include EKS and other elements but for now virtual machines are fully functional.