fix(display): correct negative BigInt rendering in fmtTokenAmount and formatBigInt - #68
Open
Sertug17 wants to merge 1 commit into
Open
fix(display): correct negative BigInt rendering in fmtTokenAmount and formatBigInt#68Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
… formatBigInt Fixes base#66
|
@Sertug17 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
🟡 Heimdall Review Status
|
Author
|
Hey @montycheese @haardikk21 small display bug fix here, would appreciate a review when you get a chance. Happy to adjust if anything looks off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes negative token amounts displaying as
"-1.-5 ETH"instead of"-1.5 ETH".Root cause
JavaScript's BigInt
%operator preserves the sign of the dividend. For negativevalue, the fractional part was also negative, producing a-prefix in the fraction string that got concatenated into the output.Fix
Use absolute value for all fractional arithmetic and prepend the sign explicitly.
Affected files
app/vibenet/library/explorer.tsfmtTokenAmountapp/tips/library/format.tsformatBigIntTesting
Closes #66