Skip to content

fix(benchmark): encode URL state as UTF-8 before base64 - #67

Open
dumanoglu1 wants to merge 1 commit into
base:mainfrom
dumanoglu1:fix/unicode-search-param-state
Open

fix(benchmark): encode URL state as UTF-8 before base64#67
dumanoglu1 wants to merge 1 commit into
base:mainfrom
dumanoglu1:fix/unicode-search-param-state

Conversation

@dumanoglu1

Copy link
Copy Markdown

Summary

  • add UTF-8 safe encode/decode helpers for benchmark URL state
  • use the helpers on both read and write paths instead of passing JSON directly to btoa/atob
  • add a regression test covering non-Latin1 punctuation in persisted filter state

Fixes #65.

Testing

  • npx vitest run app/benchmark/utils/useSearchParamsState.test.ts
  • npm run typecheck
  • npm run lint
  • git diff --check

Note: local install reported existing npm audit findings and Node engine warnings because this machine runs Node 21.6.1 while the repo declares Node 24.x. Lint passed with existing img-element warnings outside the touched files.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

@omerbek is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@dumanoglu1
dumanoglu1 force-pushed the fix/unicode-search-param-state branch from 02a90c9 to 0230666 Compare August 14, 2026 18:17
@dumanoglu1
dumanoglu1 force-pushed the fix/unicode-search-param-state branch from 0230666 to 3c902ee Compare August 14, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

benchmark URL state encoding throws for non-Latin1 values

2 participants