fix(scripts): handle optional leading slash in mintignore directory patterns - #1820
Open
dumanoglu1 wants to merge 1 commit into
Open
fix(scripts): handle optional leading slash in mintignore directory patterns#1820dumanoglu1 wants to merge 1 commit into
dumanoglu1 wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updated
loadMintIgnore()so directory patterns ending in/*work both with and without a leading slash, and added a focusednode:testregression test.Why
The parser previously used
trimmed.slice(1, -2)for every directory pattern, assuming entries were written like/foo/*. A slashless pattern likefoo/*was stored asoo, so the intended directory was never ignored.Fixes #1819
Validation
node --test scripts/lib/docs-utils.test.jsnode --check scripts/llms.jsnode --check scripts/agents.jsnode --check scripts/lib/docs-utils.jsnode --check scripts/lib/docs-utils.test.jsgit diff --check -- scripts/lib/docs-utils.js scripts/lib/docs-utils.test.js