[aviruthen]

Summary

The Training Recipes clone helper _run_clone_command_silent exists in two places (sagemaker-train and sagemaker-core modules). Its HTTPS failure handling has drifted from sagemaker.core.git_utils._run_clone_command. This change brings both copies in line with git_utils, so a failed recipe clone produces the same URL formatting and exception shape everywhere in the SDK.

Changes

• sagemaker-train/src/sagemaker/train/utils.py and sagemaker-core/src/sagemaker/core/modules/utils.py:
  • Reuse the existing URL helper from sagemaker.core.git_utils when reporting an HTTPS clone failure.
  • Raise a new CalledProcessError built from the formatted URL (from None). This matches git_utils._run_clone_command and keeps tracebacks to a single, clean exception.
  • Error log messages use the same formatted URL as the raised exception.
• Successful clones and the SSH code path are unchanged.

Testing

• Added sagemaker-train/tests/unit/train/test_utils_clone.py and sagemaker-core/tests/unit/modules/test_utils_clone.py, which cover:
  • failure with userinfo in the URL (formatted URL in the log and exception, return code preserved)
  • failure with a plain URL (URL unchanged)
  • success (original URL passed to git clone, GIT_TERMINAL_PROMPT=0 still set)
• Existing suites pass: sagemaker-train recipe tests, sagemaker-core tests/unit/modules, and tests/unit/test_git_utils.py.
• black and flake8 are clean on the changed files.

[github-actions]

🤖 AI code review

This PR aligns the HTTPS failure path of _run_clone_command_silent in both sagemaker-train and sagemaker-core with sagemaker.core.git_utils._run_clone_command: it redacts credentials from the URL via the existing _redact_credentials_from_url helper, reconstructs a CalledProcessError with the sanitized command, logs the safe URL, and re-raises from None. The SSH path is correctly left unchanged, consistent with prior git_utils work (PR #5811/#5812). New unit tests cover sanitized-failure, plain-URL, and success cases in both modules. The change is correct, well-scoped, and adequately tested; I found no issues.

_{Reviewed commit b8cb194. Automated review; verify before acting.}