[yacovm]

This PR makes the child block inherit the timestamp of the parent if it's later. This makes the timestamp non-decreasing as in the proposerVM.

[samliok]

This PR makes the child block inherit the timestamp of the parent if it's later. This makes the timestamp non-decreasing as in the proposerVM.

Two questions

1. Will a block verify if its child block has a lower timestamp than the parent?

• Seems like we would reject it in verifyTimestamp?

2. If yes to question 1, why don't we just check if child block has a lower timestamp and only then set the timestamp to the parent. Otherwise set it to now

[yacovm]

This PR makes the child block inherit the timestamp of the parent if it's later. This makes the timestamp non-decreasing as in the proposerVM.

Two questions

1. Will a block verify if its child block has a lower timestamp than the parent?

• Seems like we would reject it in verifyTimestamp?

2. If yes to question 1, why don't we just check if child block has a lower timestamp and only then set the timestamp to the parent. Otherwise set it to now

The problem here is that if a block has a timestamp that is lower than its parent, it is an illegal block and verifyTimestamp rejects it.

If yes to question 1, why don't we just check if child block has a lower timestamp and only then set the timestamp to the parent. Otherwise set it to now

That's what we do though:

	if timestamp.Before(parentTime) {
		timestamp = parentTime
	}

[samliok]

same comments about the test as the other pr

#670 (comment)
#670 (comment)